I think that Emma has been coddled all of her life and that Mr. Knightly knows that he would be a disservice of his friend by not trying to bring out her potential. I think he sees the potential and knows she can do better if she would apply herself. I really don't find that annoying (though I can understand why you think so), but rather endearing. I think it just shows how deep their friendship has become over the years.